Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary wheels don't support numpy 2.0 #36

Closed
ajb5d opened this issue Jul 12, 2024 · 3 comments
Closed

Binary wheels don't support numpy 2.0 #36

ajb5d opened this issue Jul 12, 2024 · 3 comments

Comments

@ajb5d
Copy link

ajb5d commented Jul 12, 2024

It looks like the binary wheels for ts2vg don't support numpy 2.0. I'm getting this error when I use ts2vg installed via the macOS wheel:

A module that was compiled using NumPy 1.x cannot be run in
NumPy 2.0.0 as it may crash. To support both 1.x and 2.x
versions of NumPy, modules must be compiled with NumPy 2.0.
Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.

If you are a user of the module, the easiest solution will be to
downgrade to 'numpy<2' or try to upgrade the affected module.
We expect that some modules will need time to support NumPy 2.

Building from source fixes this issue. I think pushing a new release to pypi is all that is needed. We ran into this in our CI pipeline (neuropsychology/NeuroKit#1009)

@CarlosBergillos
Copy link
Owner

Thanks for reporting! I'll take a look.

@CarlosBergillos
Copy link
Owner

I've just published a new version of ts2vg (1.2.4) to address this (and some other very minor setup improvements).
The wheels for ts2vg 1.2.4 should be compatible with both NumPy 1.xx and NumPy 2.0.
Please check if it's solved.

Unfortunately I've had to drop support for Python 3.6-3.8, since numpy 2.0 is not compatible with those.
Users in Python 3.6-3.8 can continue using ts2vg by using ts2vg<1.2.4 and numpy<2.0.

@ajb5d
Copy link
Author

ajb5d commented Jul 14, 2024

Thanks! this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants