Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts2vg binary wheel doesn't support numpy 2.0 and can't be used in CI #1009

Closed
ajb5d opened this issue Jul 12, 2024 · 5 comments
Closed

ts2vg binary wheel doesn't support numpy 2.0 and can't be used in CI #1009

ajb5d opened this issue Jul 12, 2024 · 5 comments

Comments

@ajb5d
Copy link
Contributor

ajb5d commented Jul 12, 2024

During my work on #1007 I noted that CI fails when you call ecg_findpeaks with the the vgraph method -- the package ts2vg currently requires numpy <2.0 but we don't pin a version and some package solves will pull an incompatible version. ts2vg is only used in _ecg_findpeaks_visibilitygraph and isn't included as a general dependency.

Copy link

welcome bot commented Jul 12, 2024

Hi 👋 Thanks for reaching out and opening your first issue here! We'll try to come back to you as soon as possible. ❤️ kenobi

@ajb5d ajb5d changed the title ts2vg doesn't support numpy 2.0 ts2vg binary wheel doesn't support numpy 2.0 Jul 12, 2024
@ajb5d ajb5d changed the title ts2vg binary wheel doesn't support numpy 2.0 ts2vg binary wheel doesn't support numpy 2.0 and can't be used in CI Jul 12, 2024
@ajb5d
Copy link
Contributor Author

ajb5d commented Jul 12, 2024

A follow up detail -- building ts2vg from source works fine. I think the issue is that the binary wheel that's available needs to be rebuilt against numpy 2.0. I think the ts2vg package needs to be re-published to pypi

@DominiqueMakowski
Copy link
Member

is there anything we can do on NK side?

@ajb5d
Copy link
Contributor Author

ajb5d commented Jul 12, 2024

I think options would be:

  1. Pin to numpy < 2.0
  2. Adjust CI to install ts2vg from source

Neither one of these feels super attractive. I opened an issue with ts2vg (CarlosBergillos/ts2vg#36) to see if they can just push a new version.

@ajb5d
Copy link
Contributor Author

ajb5d commented Jul 14, 2024

ts2vg 1.2.4 was released today and fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants