-
-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ts2vg binary wheel doesn't support numpy 2.0 and can't be used in CI #1009
Comments
A follow up detail -- building ts2vg from source works fine. I think the issue is that the binary wheel that's available needs to be rebuilt against numpy 2.0. I think the ts2vg package needs to be re-published to pypi |
is there anything we can do on NK side? |
I think options would be:
Neither one of these feels super attractive. I opened an issue with ts2vg (CarlosBergillos/ts2vg#36) to see if they can just push a new version. |
ts2vg 1.2.4 was released today and fixes this. |
During my work on #1007 I noted that CI fails when you call
ecg_findpeaks
with the the vgraph method -- the packagets2vg
currently requires numpy <2.0 but we don't pin a version and some package solves will pull an incompatible version. ts2vg is only used in_ecg_findpeaks_visibilitygraph
and isn't included as a general dependency.The text was updated successfully, but these errors were encountered: