-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sf): deploy analytics toolbox native app #454
Merged
Jesus89
merged 28 commits into
main
from
feature/sc-353844/build-analytics-toolbox-native-app-package
Dec 19, 2023
Merged
feat(sf): deploy analytics toolbox native app #454
Jesus89
merged 28 commits into
main
from
feature/sc-353844/build-analytics-toolbox-native-app-package
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been linked to Shortcut Story #353844: Build Analytics Toolbox Native App Package. |
jgoizueta
approved these changes
Dec 18, 2023
Jesus89
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Jesus89
deleted the
feature/sc-353844/build-analytics-toolbox-native-app-package
branch
December 19, 2023 18:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut
This PR includes the infrastructure to deploy automatically Native Apps versions. Contains some logic to, depending on which kind of version change we have deploy a whole new version, patch, delete previous versions to not surpass the 2 versions limits. Notice that the uploaded versions are called
v<major>
(v1, v2...) and then we include the whole version in the label so it will be still visible by the customers.Also will deploy a native app on each merge in order to check that the upgrade keeps doing successfully, as it could crash if anyone use a Temp table in a procedure for instance.
I included a simple README even if this package is not focused on production.
Type of change
Acceptance
I've run some test regarding deployment, re-deployment, updating versions, seeing which functions are available: https://app.shortcut.com/cartoteam/story/367433/native-apps-installation-qa