Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added River map #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added River map #10

wants to merge 2 commits into from

Conversation

albertoac
Copy link
Contributor

No description provided.

@albertoac albertoac requested a review from borja-munoz October 5, 2020 16:10
<script type="text/javascript">

deck.carto.setDefaultCredentials({
username: "mamataakella",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move the dataset to the public user here

Comment on lines +10 to +17
body {
margin: 0;
padding: 0;
}
#map {
width: 100vw;
height: 100vh;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the rest of examples right now this have been moved to inline styles

Comment on lines +3 to +7
<script src="https://unpkg.com/deck.gl@^8.1.0/dist.min.js"></script>
<script src="https://unpkg.com/@deck.gl/carto@latest/dist.min.js"></script>

<script src="https://api.tiles.mapbox.com/mapbox-gl-js/v1.4.0/mapbox-gl.js"></script>
<link href="https://api.tiles.mapbox.com/mapbox-gl-js/v1.4.0/mapbox-gl.css" rel="stylesheet" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update now that we have 8.3.0

@@ -126,6 +126,30 @@ <h3>Layer selector</h3>
<span>Fewer</span>
<span class="right-align">More</span>
</p>

<div class="input">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file now has been removed

@albertoac
Copy link
Contributor Author

Hi @VictorVelarde , Sorry I forgot to update about this. I left this as WiP before going on holidays and didn't update it. Should I keep working on the demo? As I think it was not clear at the end if it was going to be published or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants