Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check geom_coverage and print a message if None #1695

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Check geom_coverage and print a message if None #1695

merged 1 commit into from
Oct 6, 2020

Conversation

Jesus89
Copy link
Member

@Jesus89 Jesus89 commented Oct 5, 2020

Adding a check to avoid raising an exception.

NOTE: summary code has no tests, it will be covered in the future as part of this task #1323

@Jesus89 Jesus89 requested a review from antoniocarlon October 6, 2020 06:23
antoniocarlon
antoniocarlon approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@antoniocarlon antoniocarlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@antoniocarlon antoniocarlon merged commit 9e7f6e7 into develop Oct 6, 2020
@antoniocarlon antoniocarlon deleted the bug/ch108219/check-null-geom-coverage branch October 6, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoniocarlon antoniocarlon antoniocarlon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jesus89 @antoniocarlon