Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBC and ICI tou.TV Catch-up tv channels #1442

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

pchevallier
Copy link

The changes bring 3 additional Canadian TV features:
1 - CBC (GEM) Catch-up TV channels
2 - ICI Tou.TV Catch-up TV channels
3 - (add'l bonus) fixed ICI RDI live channel

@joaopa00
Copy link
Contributor

Thanks for the patches. To be merged, it will need to be cleaned, although....

For example, we try to not use requests, but urlquick, flake8 should not complain and more things to be discussed when this is fixed.

@pchevallier
Copy link
Author

Thanks for the patches. To be merged, it will need to be cleaned, although....

For example, we try to not use requests, but urlquick, flake8 should not complain and more things to be discussed when this is fixed.

Okay, thanks for the heads up... let me fix the issues spotted by flake8, as for urlquick it will take some time to get rid of the 'requests' module.
Are there any development guidelines I could consult prior to submitting any PR for this add-on ?

@pchevallier pchevallier marked this pull request as draft December 14, 2024 12:54
@pchevallier pchevallier marked this pull request as ready for review December 14, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants