changed the color of navbar and font of the title #87
Conversation
|
Thank you, @Arunjagan12, for creating this pull request and contributing to GitHub-ReadMe! 💗 Our review team will thoroughly review the pull request and will reach out to you soon! 😇 |
github-actions
bot
added
the
gssoc23
|
Bro, do you really think this looks good? 🤔 |
src/components/App.js
Outdated
| Link={Link} | ||
| dark={true} | ||
| items={NavItems} | ||
| className="AppHeader" | ||
| > | ||
| GitHub ReadMe |
src/components/Docs.js
Outdated
| @@ -20,7 +20,7 @@ class Docs extends Component { | |||
| <div className="Docs"> | |||
| <ContainerRow fluid={true}> | |||
| <div className="col-12"> | |||
| <h1 className="display-4 AppHeading text-center"> | |||
| <h1 className="display-4 AppHeading text-center font_shadows_into_light"> | |||
There was a problem hiding this comment.
Can we have - instead of _?
src/components/Home.js
Outdated
| @@ -7,8 +7,8 @@ const Home = () => { | |||
| <Container fluid={true}> | |||
| <div className="row"> | |||
| <div className="col-12"> | |||
| <h1 className="display-4 AppHeading text-center pt-2 pb-4"> | |||
| GitHub ReadMe: Elevating Your Projects & Profile to New | |||
| <h1 className="display-4 AppHeading text-center pt-2 pb-4 font_shadows_into_light"> | |||
There was a problem hiding this comment.
Can we have - instead of _?
src/styles/App.scss
Outdated
| @@ -9,4 +9,7 @@ | |||
| .AppHeading { | |||
| font-size: 1.5em; | |||
| } | |||
| .font_shadows_into_light { | |||
There was a problem hiding this comment.
Can we have - instead of _?
|
I thought this will be better.But, if u mention what to change I will change it accordingly |
|
Let's look into other harmonious colours in the palette and and show me. |
|
@Arunjagan12 Stick to colour that will suit dark mode, currently these bright and blue don't LGTM. |
Related Issue(s)
CLoses #73
Proposed Changes
The color of the navbar and font of the production page's title has been changed.
Type of Change
Your Idea for Level (GSSoC)
Screenshots (if applicable)
Additional Notes