Closes #2519: Changing the status of dataset DOI from findable to reg… #2525
Conversation
| @@ -87,18 +87,18 @@ public String reserveIdentifier(String identifier, Map<String, String> metadata, | |||
|
|
|||
| public void registerIdentifier(String identifier, Map<String, String> metadata, DvObject dvObject) throws IOException { | |||
| String xmlMetadata = getMetadataFromDvObject(identifier, metadata, dvObject); | |||
| DOIDataCiteRegisterCache rc = findByDOI(identifier); | |||
| DOIDataCiteRegisterCache rc = Optional.ofNullable(findByDOI(identifier)) | |||
| .orElseGet(DOIDataCiteRegisterCache::new); | |||
There was a problem hiding this comment.
Files get registered directly on publication (whereas for datasets we reserve the DOI on create). And a cache entry was only been created in the reservation method. As a result DOI for files would never get unregistered because of the missing entry in the cache table.
There was a problem hiding this comment.
I'm not sure if this DOIDataCiteRegisterCache is even needed (for both datasets and files). Maybe I am missing something in the code.
There was a problem hiding this comment.
AFAICT it's mainly to keep track of the DOI status. And modifyIdentifier / deleteIdentifier depend on it to perform the correct API calls. Agree, it's not particularly obvious. Maybe we can add a follow-up issue for the rafactoring?
There was a problem hiding this comment.
Yes we can add a follow-up issue for that.
| @@ -121,6 +121,7 @@ public String getMetadataForDeactivateId(String identifier) { | |||
| resource.setTitles(Collections.singletonList("This item has been removed from publication")); | |||
| resource.setPublisher(":unav"); | |||
| resource.setPublicationYear("9999"); | |||
| resource.setCreators(Collections.singletonList(new DataCiteResource.Creator(":unav"))); | |||
There was a problem hiding this comment.
The creators field is now mandatory.
...main/java/edu/harvard/iq/dataverse/engine/command/impl/DeaccessionDatasetVersionCommand.java
Outdated
Show resolved
Hide resolved
| @@ -87,18 +87,18 @@ public String reserveIdentifier(String identifier, Map<String, String> metadata, | |||
|
|
|||
| public void registerIdentifier(String identifier, Map<String, String> metadata, DvObject dvObject) throws IOException { | |||
| String xmlMetadata = getMetadataFromDvObject(identifier, metadata, dvObject); | |||
| DOIDataCiteRegisterCache rc = findByDOI(identifier); | |||
| DOIDataCiteRegisterCache rc = Optional.ofNullable(findByDOI(identifier)) | |||
| .orElseGet(DOIDataCiteRegisterCache::new); | |||
There was a problem hiding this comment.
I'm not sure if this DOIDataCiteRegisterCache is even needed (for both datasets and files). Maybe I am missing something in the code.
diasf
deleted the
fdias-2519-change-doi-status-to-registered-on-deaccession
branch
Changing the status of dataset DOI from
findabletoregisteredwhen deaccessing it.Issue: #2519