Externalized cookie session configuration #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkorbel
force-pushed
the
feature/79-externalize_cookie_session_configuration
branch
from
b8855ce
to
5591b7e
Compare
sniewczas
changed the title
sniewczas
approved these changes
Aug 20, 2024
dataverse-webapp/src/main/java/edu/harvard/iq/dataverse/DataverseSessionConfigListener.java
Outdated
Show resolved
Hide resolved
dkorbel
force-pushed
the
feature/79-externalize_cookie_session_configuration
branch
from
5591b7e
to
4e416cd
Compare
madryk
reviewed
Aug 22, 2024
dataverse-webapp/src/main/java/edu/harvard/iq/dataverse/DataverseSessionConfigListener.java
Outdated
Show resolved
Hide resolved
madryk
reviewed
Aug 22, 2024
dataverse-webapp/src/main/java/edu/harvard/iq/dataverse/util/SystemConfig.java
Outdated
Show resolved
Hide resolved
madryk
approved these changes
Aug 22, 2024
sniewczas
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dkorbel
dkorbel commented 7 minutes ago
This PR deliver feature to externalize JSESSIONID cookie configuration:
It enables you to use session cookie in subdomains.
To use it, you need to add application properties.