Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create py.typed #189

Merged
merged 4 commits into from
Aug 18, 2024
Merged

Create py.typed #189

merged 4 commits into from
Aug 18, 2024

Conversation

Andrew-S-Rosen
Copy link
Contributor

As recommended in pep 0561, a blank py.typed marker should be included when type hints are used so downstream codes can type check with mypy and similar tools.

Andrew-S-Rosen and others added 3 commits August 16, 2024 23:08
As recommended in [pep 0561](https://peps.python.org/pep-0561/), a blank `py.typed` marker should be included when type hints are used so downstream codes can type check with `mypy` and similar tools.
@BowenD-UCB BowenD-UCB enabled auto-merge (squash) August 17, 2024 04:00
auto-merge was automatically disabled August 17, 2024 12:24

Head branch was pushed to by a user without write access

@Andrew-S-Rosen
Copy link
Contributor Author

@BowenD-UCB: The error is related to materialsproject/pymatgen#3990.

@BowenD-UCB
Copy link
Collaborator

@Andrew-S-Rosen Thanks for the heads up!
I'll bypass the test for now and merge.

@BowenD-UCB BowenD-UCB merged commit aab43e4 into CederGroupHub:main Aug 18, 2024
4 of 10 checks passed
@janosh janosh added the types Type all the things label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types Type all the things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants