-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reverse readline, test against NP1 and recover NumPy 1 dependency support #203
Conversation
4c9720a
to
a594b61
Compare
monty
fix for reverse readline
@janosh I believe this one is ready for review. I completely removed usage of The reverse readers from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good thing you noticed. strange that it read the file in reverse only to reverse it again right away. seems like unnecessary work. was that leftover by accident @BowenD-UCB?
@DanielYang59 given we're no longer reliant on materialsvirtuallab/monty#712, |
I believe we are :) Nothing missing AFAIK |
Summary
monty
reverse_readline
with built inreadline
numpy >2
pinI'm not seeing much point in using
reverse_readline
as all lines are read, and reversed immediately:chgnet/chgnet/utils/vasp_utils.py
Lines 61 to 67 in 11ff513