Split EllipticalOrbit and HyperbolicOrbit classes #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajtribick
force-pushed
the
fix-hyperbolic
branch
4 times, most recently
from
ab08736 to
73ce5c0
Compare
ajtribick
force-pushed
the
fix-hyperbolic
branch
from
73ce5c0 to
56e4180
Compare
- Store semimajor axis instead of pericenterDistance in EllipticalOrbit - Store semiminor axis to avoid some sqrt calls during evaluation - Support zero and negative mean anomaly in hyperbolic orbits - Fix velocity calculation for hyperbolic orbits - Consolidate state vector to orbital elements calculations - Extend orbital elements calculation to support hyperbolic orbits - Add tests for orbital elements calculations - Fix hyperbolic orbital elements display in Qt info panel
ajtribick
force-pushed
the
fix-hyperbolic
branch
from
56e4180 to
7a7c3a3
Compare
375gnu
approved these changes
Oct 17, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hyperbolic orbits now have the orbit line plotted (currently out to 1000 au or twice the pericenter distance, whichever is further). The eccentric anomaly calculation no longer attempts to take the logarithm of negative mean anomaly angles.