Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused/redundant draw methods from Simulation and Renderer #1960

Merged
merged 1 commit into from
Nov 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/celengine/render.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1483,14 +1483,6 @@ void Renderer::render(const Observer& observer,
const Universe& universe,
float faintestMagNight,
const Selection& sel)
{
draw(observer, universe, faintestMagNight, sel);
}

void Renderer::draw(const Observer& observer,
const Universe& universe,
float faintestMagNight,
const Selection& sel)
{
// Get the observer's time
double now = observer.getTime();
Expand Down
4 changes: 0 additions & 4 deletions src/celengine/render.h
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,6 @@ class Renderer
const Universe&,
float faintestVisible,
const Selection& sel);
void draw(const Observer&,
const Universe&,
float faintestVisible,
const Selection& sel);

bool getInfo(std::map<std::string, std::string>& info) const;

Expand Down
8 changes: 0 additions & 8 deletions src/celengine/simulation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,6 @@ void Simulation::render(Renderer& renderer)
selection);
}

void Simulation::draw(Renderer& renderer)
{
renderer.draw(*activeObserver,
*universe,
faintestVisible,
selection);
}


void Simulation::render(Renderer& renderer, Observer& observer)
{
Expand Down
1 change: 0 additions & 1 deletion src/celengine/simulation.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ class Simulation

void update(double dt);
void render(Renderer&);
void draw(Renderer&);
void render(Renderer&, Observer&);

Selection pickObject(const Eigen::Vector3f& pickRay, std::uint64_t renderFlags, float tolerance = 0.0f);
Expand Down