Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix garbled text displaying unicode #877

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Fix garbled text displaying unicode #877

merged 1 commit into from
Nov 26, 2020

Conversation

levinli303
Copy link
Collaborator

Closes #875

@levinli303
Copy link
Collaborator Author

should fix some of them in star browser, solar system browser, eclipse finder, bookmark organizer

@levinli303 levinli303 force-pushed the 1.6.x-fix-garbled-text branch from 18a79cd to 8b7f71b Compare November 20, 2020 19:24
@levinli303 levinli303 force-pushed the 1.6.x-fix-garbled-text branch from 8b7f71b to e697685 Compare November 21, 2020 05:48
@levinli303 levinli303 requested a review from 375gnu November 21, 2020 05:50
@levinli303
Copy link
Collaborator Author

always use the W version to set up list view and tree view. also fixed the issue delete a folder in bookmark organizer crashes Celestia. @RacerBG I can provide an .exe to test, but I do not know if it will be compatible with Win7, my build setup is with VS2019

@RacerBG
Copy link
Contributor

RacerBG commented Nov 21, 2020 •
edited
Loading

I can provide an .exe to test, but I do not know if it will be compatible with Win7, my build setup is with VS2019

We can try.

Windows 7 SP1 (with latest Windows Updates): Home Premium, Professional, Enterprise, Ultimate

This from Visual Studio 2019 System Requirements.

https://docs.microsoft.com/en-us/visualstudio/releases/2019/system-requirements

@levinli303
Copy link
Collaborator Author

@375gnu can you generate a binary for this PR? my setup is different, so I'm certain providing an .exe won't be sufficient from my side.

@375gnu
Copy link
Collaborator

375gnu commented Nov 21, 2020

i can but in a few days

@375gnu
Copy link
Collaborator

375gnu commented Nov 24, 2020

@RacerBG @Askaniy please test https://celestia.space/files/celestia/celestia-1.6.2.1.7z

@375gnu 375gnu added the native win Specific to native Windows frontend label Nov 24, 2020
@RacerBG
Copy link
Contributor

RacerBG commented Nov 24, 2020

@375gnu @levinli303

Good job guys, it works!

works

@375gnu 375gnu merged commit 2f80474 into 1.6.x Nov 26, 2020
@375gnu 375gnu deleted the 1.6.x-fix-garbled-text branch November 26, 2020 11:12
@levinli303 levinli303 linked an issue Nov 26, 2020 that may be closed by this pull request
[1.6.2] Solar System Browser planet names are in gibberish #875
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@375gnu 375gnu 375gnu approved these changes

Assignees
No one assigned
Labels
native win Specific to native Windows frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.6.2] Solar System Browser planet names are in gibberish
3 participants
@levinli303 @RacerBG @375gnu