Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-01-21 General data update #168

Merged
merged 13 commits into from
Jan 27, 2024
Merged

2024-01-21 General data update #168

merged 13 commits into from
Jan 27, 2024

Conversation

AstroChara
Copy link
Contributor

  • Updated rings of dwarf planets and centaurs wherever data allows; Chiron's rings are currently hidden due to not enough data being available
  • Updated Orcus' colors
  • Corrected Vanth's radius
  • Added mass for Himalia
  • Updated Chariklo's dimensions
  • Updated masses for Saturn and Neptune
  • Updated ring textures for Haumea, Quaoar (corrected opacity), and Chariklo.

Current issues:

  • Licensing of haumea-rings, as the version with fictional details has been replaced; the current license file has not yet been changed.
  • The ring textures are 2 pixels tall, as for whatever reason paint.net doesn't allow me to make them 1 pixel tall.

Quaoar's rings were made too dense in the previous version.
The ring texture was made too opaque and placed in the wrong folder.
Haumea's ring color now uses the planet's color.
@AstroChara
Copy link
Contributor Author

AstroChara commented Jan 21, 2024

As unlikely as it is, please do not merge this pull request before @Askaniy comments on the Haumea ring texture update.

@Askaniy
Copy link
Collaborator

Askaniy commented Jan 21, 2024

I don't mind replacing my texture with a detailless one.
Noticed that the height is 2 pixels, not 1, which is a little strange.

@AstroChara
Copy link
Contributor Author

AstroChara commented Jan 21, 2024

I don't mind replacing my texture with a detailless one.
Noticed that the height is 2 pixels, not 1, which is a little strange.

Thanks. After thinking about it for a bit, would it be okay to keep the license file the same, (I think) effectively 'transferring' this file to you or something like that?
paint.net doesn't allow me to scale these files down to 1 pixel unfortunately; would appreciate help on this one.

@SevenSpheres
Copy link
Contributor

You can just edit the license file to

SPDX-FileCopyrightText: 2024 AstroChara

SPDX-License-Identifier: (CC0-1.0|CC-BY-4.0|CC-BY-SA-4.0)

The other ring textures will need license files too.

Try using another program like GIMP to scale the textures.

@AstroChara
Copy link
Contributor Author

You can just edit the license file to

SPDX-FileCopyrightText: 2024 AstroChara

SPDX-License-Identifier: (CC0-1.0|CC-BY-4.0|CC-BY-SA-4.0)

The other ring textures will need license files too.

Try using another program like GIMP to scale the textures.

Done.

GIMP is godawful at transparency it's not even funny. That said I realized I could just crop the ring texture so I am going to update the textures now.

Copy link
Contributor

@SevenSpheres SevenSpheres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, though eventually Chiron will need a ring texture (or Chariklo's restored as a placeholder)

@AstroChara
Copy link
Contributor Author

AstroChara commented Jan 27, 2024

approving, though eventually Chiron will need a ring texture (or Chariklo's restored as a placeholder)

done. Due to the asymmetry in the rings, I used the denser, wider, closer portion of the rings.

@SevenSpheres SevenSpheres merged commit 7b0c43a into CelestiaProject:master Jan 27, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants