Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

International Space Station (NASA-VTAD) #219

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DaveBowman2001
Copy link
Contributor

@DaveBowman2001 DaveBowman2001 commented Nov 21, 2024

New default ISS for Celestia, serving as replacement for Andrew Farnaby's ISS model that was recently removed by PR #202

Original model was created by NASA-VTAD on 22 April 2019: https://science.nasa.gov/resource/international-space-station-3d-model/
image

New default ISS for Celestia, serving as replacement for Andrew Farnaby's ISS model that was recently removed by PR CelestiaProject#202

Original model was created by NASA-VTAD on 22 April 2019:
https://science.nasa.gov/resource/international-space-station-3d-model/
@pedro-fixingstuff
Copy link
Contributor

The README should be updated to attribute the source of the original model (and that you've edited it).

Copy link
Contributor

@ajtribick ajtribick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs .license files for assets and header comment in .ssc file

@DaveBowman2001
Copy link
Contributor Author

How do I create a .license file?

@DaveBowman2001
Copy link
Contributor Author

The README should be updated to attribute the source of the original model (and that you've edited it).

I think I already attributed the source of the original model (and indicated that I edited it) on a note I left on its ssc file:

# International Space Station
#
# This is a 3D representation of the ISS created by NASA-VTAD
# on April 22, 2019
#
# ORIGINAL LINK:
# https://science.nasa.gov/resource/international-space-station-3d-model/
#
# The configuration shown is what the ISS looked like from May
# 2011 until February 2015, shortly after STS-134 (Endeavour)
# delivered the AMS and ELC-3 pallets to the station.
#
# Model and textures were converted for use in Celestia by 
# DaveBowman2001
#
# Orbital elements used were retrieved from JPL HORIZONS using
# Epoch 2024-Nov-20 (JD 2460634.5), i.e. the station's 26th
# anniversary since launch
# https://ssd.jpl.nasa.gov/horizons/app.html#/

@ajtribick
Copy link
Contributor

You can either create them in a text editor or use the reuse tool https://github.com/fsfe/reuse-tool

Should look something like

SPDX-FileCopyrightText: Copyright 2024 Blah McBlahson

SPDX-License-Identifier: CC-BY-SA-4.0

The SPDX-License-Identifier is one of the identifiers in the list at https://spdx.org/licenses/ - it also requires that the license text exists in the LICENSES folder, if you need a license we don't have already then we can look at adding it.

@DaveBowman2001
Copy link
Contributor Author

I presume the ISS model I've used is either public domain or C.C. B.Y. 4.0 since its original authors (NASA-VTAD) were the same ones to the Cassini and Galileo models we now use by default

@pedro-fixingstuff
Copy link
Contributor

The README should be updated to attribute the source of the original model (and that you've edited it).

I think I already attributed the source of the original model (and indicated that I edited it) on a note I left on its ssc file:

Currently, the README attributes Farnaby's model:

CelestiaContent/README

Lines 272 to 279 in e80a8be

# The 3D model of ISS is a deconstruction of Andrew Farnaby's
complete ISS model with textures by Bob Hundley. The model
represents the ISS as of June 2008 and is a modification of
the model that can be found here:
http://www.celestiamotherlode.net/catalog/show_addon_details.php?addon_id=1199
ISS model of June 2008 (with Kibo) by krisci3 (modified and
converted in order to work with JPG by Ulrich Dickmann, a.k.a.
Adirondack)

I'd argue that makes attribution within the .ssc unnecessary (other than the orbital elements).

DaveBowman2001 added a commit to DaveBowman2001/CelestiaContent that referenced this pull request Nov 30, 2024
Update to the ReadMe portion for the new ISS model from NASA-VTAD, currently at PR CelestiaProject#219
Update to the ReadMe portion for the new ISS model from NASA-VTAD, currently at PR CelestiaProject#219
@DaveBowman2001
Copy link
Contributor Author

Currently, the README attributes Farnaby's model...

Just recently made changes to the ReadMe reflecting the change of the ISS to a NASA model on commit 9ef9279

README Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants