-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
International Space Station (NASA-VTAD) #219
base: master
Are you sure you want to change the base?
Conversation
New default ISS for Celestia, serving as replacement for Andrew Farnaby's ISS model that was recently removed by PR CelestiaProject#202 Original model was created by NASA-VTAD on 22 April 2019: https://science.nasa.gov/resource/international-space-station-3d-model/
The README should be updated to attribute the source of the original model (and that you've edited it). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs .license files for assets and header comment in .ssc file
How do I create a .license file? |
I think I already attributed the source of the original model (and indicated that I edited it) on a note I left on its ssc file:
|
You can either create them in a text editor or use the reuse tool https://github.com/fsfe/reuse-tool Should look something like
The SPDX-License-Identifier is one of the identifiers in the list at https://spdx.org/licenses/ - it also requires that the license text exists in the LICENSES folder, if you need a license we don't have already then we can look at adding it. |
I presume the ISS model I've used is either public domain or C.C. B.Y. 4.0 since its original authors (NASA-VTAD) were the same ones to the Cassini and Galileo models we now use by default |
Currently, the README attributes Farnaby's model: Lines 272 to 279 in e80a8be
I'd argue that makes attribution within the .ssc unnecessary (other than the orbital elements). |
Update to the ReadMe portion for the new ISS model from NASA-VTAD, currently at PR CelestiaProject#219
Update to the ReadMe portion for the new ISS model from NASA-VTAD, currently at PR CelestiaProject#219
Just recently made changes to the ReadMe reflecting the change of the ISS to a NASA model on commit 9ef9279 |
New default ISS for Celestia, serving as replacement for Andrew Farnaby's ISS model that was recently removed by PR #202
Original model was created by NASA-VTAD on 22 April 2019: https://science.nasa.gov/resource/international-space-station-3d-model/