don't show root folder for configured compute addons

CenterForOpenScience · Jan 2, 2025 · 6535fdf · 6535fdf
1 parent 41c2f7b
commit 6535fdf
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 11 deletions.
diff --git a/app/guid-node/addons/index/template.hbs b/app/guid-node/addons/index/template.hbs
@@ -194,16 +194,18 @@
                                         </Button>
                                     </span>
                                 </div>
-                                <div
-                                    data-test-configured-addon-root-folder
-                                    local-class='configured-addon-root-folder'
-                                >
-                                    {{#if configuredAddon.rootFolder}}
-                                        {{configuredAddon.rootFolder}}
-                                    {{else}}
-                                        {{t 'addons.list.root-folder-not-set'}}
-                                    {{/if}}
-                                </div>
+                                {{#if configuredAddon.hasRootFolder}}
+                                    <div
+                                        data-test-configured-addon-root-folder
+                                        local-class='configured-addon-root-folder'
+                                    >
+                                        {{#if configuredAddon.rootFolder}}
+                                            {{configuredAddon.rootFolder}}
+                                        {{else}}
+                                            {{t 'addons.list.root-folder-not-set'}}
+                                        {{/if}}
+                                    </div>
+                                {{/if}}
                                 <div local-class='configured-addon-connected-to'>
                                     {{t 'addons.list.connected-to-account'}} {{configuredAddon.baseAccount.displayName}}
                                 </div>

diff --git a/app/models/configured-addon.ts b/app/models/configured-addon.ts
@@ -37,4 +37,8 @@ export default class ConfiguredAddonModel extends Model {
         // To be implemented in child classes
         return;
     }
+
+    get hasRootFolder() {
+        return true;
+    }
 }
diff --git a/app/models/configured-computing-addon.ts b/app/models/configured-computing-addon.ts
@@ -18,6 +18,11 @@ export default class ConfiguredComputingAddonModel extends ConfiguredAddonModel
     get externalServiceId() {
         return (this as ConfiguredComputingAddonModel).belongsTo('externalComputingService').id();
     }
+
+    get hasRootFolder() {
+        return false;
+    }
+
 }
 
 declare module 'ember-data/types/registries/model' {

diff --git a/lib/osf-components/addon/components/addons-service/configured-addon-edit/component.ts b/lib/osf-components/addon/components/addons-service/configured-addon-edit/component.ts
@@ -7,6 +7,7 @@ import { Item, ItemType } from 'ember-osf-web/models/addon-operation-invocation'
 import AuthorizedAccountModel from 'ember-osf-web/models/authorized-account';
 import AuthorizedComputingAccountModel from 'ember-osf-web/models/authorized-computing-account';
 import ConfiguredAddonModel from 'ember-osf-web/models/configured-addon';
+import ConfiguredComputingAddonModel from 'ember-osf-web/models/configured-computing-addon';
 
 
 interface Args {
@@ -25,7 +26,11 @@ export default class ConfiguredAddonEdit extends Component<Args> {
     };
 
     get hasRootFolder() {
-        return !(this.args.authorizedAccount instanceof AuthorizedComputingAccountModel);
+        return !(
+            this.args.authorizedAccount instanceof AuthorizedComputingAccountModel
+            ||
+            this.args.configuredAddon instanceof ConfiguredComputingAddonModel
+        );
     }
 
     get invalidDisplayName() {