-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-6744] FE: Contributors can "configure" others' addons #2438
[ENG-6744] FE: Contributors can "configure" others' addons #2438
Conversation
… addon, fixed user and resource reference reuest swarm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks really good. I have got one question. The ticket requires that the admin should be able to delete the addons that others have configured. So that means in the page after the "Configure" button is clicked, the pencil button should not be there. Does this PR remove the pencil buttons for admins when they try to configure addons that others have configured?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the screenshot in this PR is from the perspective of someone who isn't a project admin, but is the owner of the connected Box and Google Drive account, correct?
Yeah, you are right on the spot. Also, I've updated screenshot to include not already confgured addons |
70a71e8
into
CenterForOpenScience:feature/addon-services
…
Purpose
Summary of Changes
Screenshot(s)
Side Effects
QA Notes