Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-5701][ENG-5702] Account migrations #170

Merged

Conversation

opaduchak
Copy link
Collaborator

Implemented account migrations for every service except:

  • Figshare
  • Mendeley

@opaduchak opaduchak requested review from sh-andriy and adlius December 2, 2024 12:17
@opaduchak opaduchak force-pushed the feature/account-migrations branch from b71f4c3 to 0d853b4 Compare December 2, 2024 15:27
@opaduchak opaduchak force-pushed the feature/account-migrations branch from 0d853b4 to a02f537 Compare December 2, 2024 15:35
@@ -316,7 +316,7 @@ async def refresh_oauth2_access_token(self) -> None:
_oauth_client_config,
_oauth_token_metadata,
) = await self._load_oauth2_client_config_and_token_metadata()
if sync_to_async(lambda: _oauth_token_metadata.access_token_only)():
if await sync_to_async(lambda: _oauth_token_metadata.access_token_only)():
Copy link
Collaborator Author

@opaduchak opaduchak Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fix to bug intoduced before (while fixing github quirks)

Copy link
Collaborator

@adlius adlius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@opaduchak opaduchak merged commit fc56b2d into CenterForOpenScience:develop Dec 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants