Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6774] export terms and conditions for boa/computing addons #197

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

felliott
Copy link
Member

Changes

  • Update supported features list for computing addons
  • Make sure those supported features are properly serialized so the terms-and-conditions page can be rendered
  • Fix up Computing addon instantiation code to correctly instantiate.

@felliott felliott changed the title [WIP][ENG-6774] export terms and conditions for boa/computing addons [ENG-6774] export terms and conditions for boa/computing addons Dec 30, 2024
@felliott felliott requested a review from opaduchak December 30, 2024 16:51
 * Update list of supporeted features and make sure to export in the
   serializer.
@felliott felliott force-pushed the feature/boa-t-and-c branch from 089bf26 to d00a0ff Compare December 31, 2024 01:37
Copy link
Collaborator

@opaduchak opaduchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felliott felliott merged commit dcc19aa into CenterForOpenScience:develop Jan 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants