Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static type checking (but loose-like around dependencies) #28

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

aaxelb
Copy link
Collaborator

@aaxelb aaxelb commented Mar 29, 2024

  • add mypy to pre-commit config
  • add mypy.ini: set strict mode by default, then loosen by path to accomodate
    • addon_toolkit depends only on python 3.12, can be (mostly) strictly typed (and empower imp(lementer)s' editors' generative ai to make more convincingly valid choices)
    • addon_service has much looser type-checking (what with all the frameworks) and it's mostly opt-in (by adding type annotations)
  • fix easy-to-fix type errors

@aaxelb aaxelb marked this pull request as ready for review March 29, 2024 21:02
@aaxelb aaxelb force-pushed the quest/mypy branch 3 times, most recently from c9534ba to f3ccdee Compare April 10, 2024 20:52
@aaxelb aaxelb changed the base branch from develop to followup/invocation-tests April 10, 2024 20:53
@aaxelb aaxelb force-pushed the followup/invocation-tests branch from 0da80f0 to 18294f6 Compare April 29, 2024 15:43
@aaxelb aaxelb changed the base branch from followup/invocation-tests to develop May 3, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant