Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no-binary for psycopg2 #60

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

XanderVertegaal
Copy link
Contributor

Psycopg is now on version 2.9, so the --no-binary flag can be removed (at least on my system).

The README suggests that we can use pip-sync instead of pip install -r requirements.txt for our yarn shortcut commands, but the note in CONTRIBUTING.md suggests that that is not the case, so I've left them as they are.

Copy link
Contributor

@jgonggrijp jgonggrijp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip-sync is more reproducible because it also removes packages that we no longer depend on. However, I recall it not playing nice with deployment, so it's fine to leave the package.json as-is.

@XanderVertegaal XanderVertegaal merged commit 5a038e1 into develop Dec 9, 2024
4 checks passed
@XanderVertegaal XanderVertegaal deleted the feature/psycopg-remove-no-binary branch December 9, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants