Fix spurious agent duplication bug

CentreForDigitalHumanities · Dec 9, 2024 · 9fcc99c · 9fcc99c
1 parent 2d15266
commit 9fcc99c
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/backend/event/types/EpisodeType.py b/backend/event/types/EpisodeType.py
@@ -5,10 +5,14 @@
 
 from event.models import Episode, EpisodeCategory
 from event.types.EpisodeCategoryType import EpisodeCategoryType
+from person.models import AgentDescription
 
 
 class EpisodeType(EntityDescriptionType, DjangoObjectType):
     categories = List(NonNull(EpisodeCategoryType), required=True)
+    agents = List(
+        NonNull("person.types.AgentDescriptionType.AgentDescriptionType"), required=True
+    )
 
     class Meta:
         model = Episode
@@ -17,7 +21,6 @@ class Meta:
             "summary",
             "categories",
             "designators",
-            "agents",
             "gifts",
             "letters",
             "spaces",
@@ -32,6 +35,14 @@ def get_queryset(
     ) -> QuerySet[Episode]:
         return queryset.all()
 
+    @staticmethod
+    def resolve_agents(
+        parent: Episode, info: ResolveInfo
+    ) -> QuerySet[AgentDescription]:
+        # Without distinct(), this returns one agent for every HistoricalPerson linked
+        # to that agent, for some reason.
+        return parent.agents.distinct()
+
     @staticmethod
     def resolve_categories(
         parent: Episode, info: ResolveInfo