Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model changes for Letter #10

Closed
XanderVertegaal opened this issue Jan 25, 2024 · 1 comment · Fixed by #17
Closed

Model changes for Letter #10

XanderVertegaal opened this issue Jan 25, 2024 · 1 comment · Fixed by #17
Assignees

Comments

@XanderVertegaal
Copy link
Contributor

  • Change representation in Django Admin. Instead of "letter Names => Designators #57" there should be a name / one-line identifier so the team can quickly find/identify new letters, e.g. ('No. 60: Boniface to pope Zacharias in 578')
  • Add sender
  • Add addressee
  • Add date
  • Add type (e.g. 'friendship letter', 'consensus letter', 'royal order'). This could be an editable category in its own right?
  • Instead of certainty, two new fields: historically_attested (letter features in actual, historical events vs. letter features in story/legend/fairytale) and mentioned: (letter is directly mentioned vs. existence of letter is implied/possible).
@lukavdplas
Copy link
Contributor

I would think that the sender, addressee and date fields can be inferred from the actions/roles associated with the letter?

@lukavdplas lukavdplas linked a pull request Feb 1, 2024 that will close this issue
@lukavdplas lukavdplas moved this from Todo to In Progress in Lettercraft Feb 9, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Lettercraft Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants