Feature/letter model updates #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
XanderVertegaal
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
All good changes! I think Hope and Robert will be pleased now letters will have names that are more insightful than simply 'letter #4' vel sim.
(I'm glad you added the link to the Django docs about the three migration scripts needed to insert a unique non-nullable field. It would have been quite confusing otherwise. ;))
| return self._aggregate_dates(self.events.all()) | ||
|
|
||
| @admin.display( | ||
| description="Date range in which this letter was written", |
There was a problem hiding this comment.
This is great! Good idea to add this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the data model for letters (close #10)
namefield to letters, which is required and unique, and used as the string representation. It will default to the currentletter #3string representation during the migration, though if you run this right after Feature/separate apps #16, this doesn't really matter. Note that this operation requires 3 (!) migration scripts, following django documentation on adding unique non-nullable fields.categoryfield to letters. Letter categories are a model by themselves, so researchers can add or remove categories as needed.date_activeanddate_writtenreadonly fields to the admin interface. The values of these fields is based on the actions associated with the letter. They give the date range of, respectively, all actions involving the letters, and the "writing" actions involving the letter.addresseesandsendersfields to letters.