Feature/episode order #154
Conversation
XanderVertegaal
requested review from
lukavdplas
and removed request for
lukavdplas
|
This PR will be adjusted to replace the drag and drop interface with buttons to move episodes 'up'/'down' in the hierarchy. |
| rank = models.IntegerField( | ||
| default=0, | ||
| help_text="The relative position of this description in the source", | ||
| ) | ||
|
|
There was a problem hiding this comment.
Django's order_with_respect_to would create an _order field that is configured exactly like this. We are ordering episodes within each source, so order_with_respect_to = 'source' would make sense.
Since order_with_respect_to is the canonical way of handling this situation and this implementation is essentially replicating it, I would prefer that we take that route.
| class EpisodeOrderInput(InputObjectType): | ||
| id = ID(required=True) | ||
| rank = Int(required=True) | ||
|
|
||
|
|
||
| class UpdateEpisodeOrderMutation(Mutation): | ||
| ok = Boolean(required=True) | ||
| errors = List(NonNull(LettercraftErrorType), required=True) | ||
|
|
||
| class Arguments: | ||
| episode_order_data = List(NonNull(EpisodeOrderInput), required=True) | ||
|
|
There was a problem hiding this comment.
Providing the rank in the input isn't really necessary, you can also just use an ordered list of IDs as input.
This will probably make more sense if you use order_with_respect_to, since you could then set the order with something like:
source = Source.objects.get(episodes__in=episode_ids) # should be unique
source.set_episode_order(episode_ids)This isn't a huge deal though, the current argument structure is superfluous but clear.
| def mutate(cls, root: None, info: ResolveInfo, episode_order_data: list[EpisodeOrderInput]): | ||
| # Map Episode IDs to new rank values | ||
| id_to_rank: dict[int, int] = { | ||
| int(episode.id): episode.rank for episode in episode_order_data | ||
| } |
There was a problem hiding this comment.
I think these type declarations need to be List and Dict instead of list and dict, right?
|
I will reopen another PR with |
Closes #122
Adds a
rankproperty to objects inheriting EntityDescription and allows the user to drag/drop episodes in a source's episode overview to reorder them (using Angular Material's CDK).I'd be happy to discuss alternatives if you think rank-based ordering or a drag-and-drop interface are not the way to go.