Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: delete user #157

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Feature: delete user #157

merged 3 commits into from
Nov 26, 2024

Conversation

XanderVertegaal
Copy link
Contributor

Closes #66.

This PR allows users to delete their own accounts (in the user settings menu). A pop-up is shown to confirm before deletion actually takes place.

Strangely, user deletion with django-allauth does not work without the socialaccount app installed, as documented here and here. The code behind user.delete() tries to delete associated records from socialaccount tables that are only created when the app is added to INSTALLED_APPS and migrations are applied. Make sure to run migrations after switching to this branch!

@XanderVertegaal XanderVertegaal added the enhancement New feature or request label Nov 22, 2024
@XanderVertegaal XanderVertegaal linked an issue Nov 22, 2024 that may be closed by this pull request
Copy link
Contributor

@lukavdplas lukavdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that socialaccounts is required, but whatever. Looks good!

Base automatically changed from fix/confirm-email to develop November 26, 2024 13:09
@XanderVertegaal XanderVertegaal merged commit 086fe2a into develop Nov 26, 2024
2 checks passed
@XanderVertegaal XanderVertegaal deleted the feature/delete-user branch November 26, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Delete User
2 participants