Feature/source description split (agents, spaces) #48
Conversation
lukavdplas
changed the title
| source = models.ForeignKey( | ||
| to=Source, | ||
| on_delete=models.PROTECT, |
There was a problem hiding this comment.
Why no CASCADE here? Is there something wrong with deleting associated descriptions when a source is removed?
There was a problem hiding this comment.
It's not really an issue on a technical level, but sources are quite fundamental, you can accidentally remove half the database that way. 🙃
| return f"{self.person} died c. {self.year_lower}-{self.year_upper}" | ||
|
|
||
|
|
||
| class PersonReference(Field, models.Model): |
There was a problem hiding this comment.
Am I correct in assuming you will want to add more properties to this relationship in the future?
(I'm a bit confused why this is not simply a ForeignKey.)
There was a problem hiding this comment.
It's inherits Field, it has the certainty and note properties! I thought those would be useful.
There was a problem hiding this comment.
Ah right, sorry; I missed that one.
|
|
||
| class PersonDateOfBirth(Field, LettercraftDate, models.Model): | ||
| person = models.OneToOneField( | ||
| to=HistoricalPerson, |
There was a problem hiding this comment.
I'm a bit confused as to why DateOfBirth and DateOfDeath are directly linked to HistoricalPerson, while Gender would be linked to AgentDescription.
I expect dates to be a lot more controversial and source-dependent.
There was a problem hiding this comment.
I wasn't really sure about this, it's true that it's not really consistent.
I think it makes sense to me because I'm not a historian but I have some background in queer theory, so I see dates as boring background information, and representations of gender as dynamic and interesting. That framing depends on research interest, though.
|
|
||
| def clean(self): | ||
| if self.location.source != self.agent.source: | ||
| raise ValidationError("Can only link descriptions in the same source text") |
This re-does part of #45 - creating a split between historical constructs and descriptions in narrative sources. Refactoring was done to avoid the duplication of every entity having both a Historical and SourceDescription version, which is not always needed.
core.spaceapp. These changes are quite minor, mostly adding some fields for where/how information is represented in the source. SpaceDescriptions now require a source - the migrations add a "MISSING SOURCE" object as a placeholder.agentapp, which is more radical. TheAgentmodel is split intoHistoricalPersonandAgentDescription. I decided to simply delete all existing agents from the database, rather than converting them into one of the new models. For existing agents, we don't actually know if they are described in narrative sources or not.Updates for
letterandeventwill follow later, but I wanted to avoid a massive PR.Notes:
letter/eventapps are commented out because they refer to agents (which were deleted).HistoricalPersonis a single person, while an agent can also be a group. This is because identifying groups as "historical figures" can get ship-of-Theseus-y. It's also less relevant for users.