Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend cleanup #6

Merged
merged 14 commits into from
Nov 27, 2023
Merged

frontend cleanup #6

merged 14 commits into from
Nov 27, 2023

Conversation

lukavdplas
Copy link
Contributor

close #4

We won't be developing the frontend for a while; this update just makes a bunch of changes that are easier to do before you start actual development.

  • update angular, and everything that depends on it
  • use bootstrap for CSS (mainly because it has better accessibility support)
  • add a SharedModule and CoreModule

Copy link
Contributor

@XanderVertegaal XanderVertegaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mooi, dat voorkomt een enorme dependency hell wanneer we daadwerkelijk aan de frontend gaan beginnen. Ook fijn om alvast modules klaar te hebben.

Approved!

PS.
image

@@ -2,7 +2,8 @@
"$schema": "./node_modules/@angular/cli/lib/config/schema.json",
"version": 1,
"cli": {
"packageManager": "yarn"
"packageManager": "yarn",
"analytics": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks, it kept asking about this during deployment :P

@lukavdplas lukavdplas merged commit e783ecb into main Nov 27, 2023
2 checks passed
@lukavdplas lukavdplas deleted the feature/frontend-libraries branch November 27, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to angular 16
2 participants