Skip to content

Commit

Permalink
Delete TODO statements that have been done.
Browse files Browse the repository at this point in the history
  • Loading branch information
cboulay committed Oct 20, 2024
1 parent a9529ff commit f2014ea
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions src/pycbsdk/cbhw/device/nsp.py
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,7 @@ def _handle_chaninfo(self, pkt):
self._config["channel_infos"][pkt.chan].smpgroup = pkt.smpgroup
elif pkt.header.type == CBPacketType.CHANREPSPKHPS:
self._config["channel_infos"][pkt.chan].spkhoops = pkt.spkhoops
# TODO: .unitmapping[n].bValid = pkt.spkhoops[n][0].valid ??
elif pkt.header.type == CBPacketType.CHANREPAOUT:
self._config["channel_infos"][pkt.chan].aoutopts = pkt.aoutopts
# self._config["channel_infos"][pkt.chan].union.a.moninst = pkt.moninst
Expand All @@ -443,12 +444,7 @@ def _handle_chaninfo(self, pkt):
else:
# TODO: from CHANREPNTRODEGROUP, .spkgroup
# TODO: from CHANREPDISP, .smpdispmin, .smpdispmax, .spkdispmax, .lncdispmax
# TODO: from CHANREPLABEL, .label, .userflags
# TODO: from CHANREPUNITOVERRIDES, .unitmapping
# TODO: from CHANREPSPKHPS, .spkhoops, .unitmapping[n].bValid = pkt.spkhoops[n][0].valid
# TODO: from CHANREPDINP, .dinpopts; NOTE: Need extra check if this is for serial or digital
# TODO: from CHANREPAOUT, ... complicated
# TODO: from CHANREPSCALE, .scalin, .scalout
pass
# print(f"handled chaninfo {pkt.chan} of type {hex(pkt.header.type)}")
self._config_events["chaninfo"].set()
Expand Down

0 comments on commit f2014ea

Please sign in to comment.