Add remaining errno checks

CesiumGS · Jan 10, 2024 · f6a71d8 · f6a71d8
1 parent fbad0f5
commit f6a71d8
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/CesiumGltf/include/CesiumGltf/MetadataConversions.h b/CesiumGltf/include/CesiumGltf/MetadataConversions.h
@@ -414,9 +414,12 @@ template <> struct MetadataConversions<float, std::string> {
       return std::nullopt;
     }
 
+    errno = 0;
+
     char* pLastUsed;
     float parsedValue = std::strtof(from.c_str(), &pLastUsed);
-    if (pLastUsed == from.c_str() + from.size() && !std::isinf(parsedValue)) {
+    if (errno == 0 && pLastUsed == from.c_str() + from.size() &&
+        !std::isinf(parsedValue)) {
       // Successfully parsed the entire string as a float.
       return parsedValue;
     }
@@ -519,9 +522,12 @@ template <> struct MetadataConversions<double, std::string> {
       return std::nullopt;
     }
 
+    errno = 0;
+
     char* pLastUsed;
     double parsedValue = std::strtod(from.c_str(), &pLastUsed);
-    if (pLastUsed == from.c_str() + from.size() && !std::isinf(parsedValue)) {
+    if (errno == 0 && pLastUsed == from.c_str() + from.size() &&
+        !std::isinf(parsedValue)) {
       // Successfully parsed the entire string as a double.
       return parsedValue;
     }