Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CesiumGltf to use std::vector<std::byte> rather than std::vector<uint8_t> #117

Closed
kring opened this issue Jan 29, 2021 · 3 comments
Closed
Assignees

Comments

@kring
Copy link
Member

kring commented Jan 29, 2021

It probably doesn't make much practical difference, but std::byte is slightly clearer semantically.

As suggested by @Samulus in #106.

@kring kring mentioned this issue Jan 29, 2021
@kring kring added this to the Initial Release milestone Feb 25, 2021
@javagl javagl self-assigned this Mar 3, 2021
@javagl
Copy link
Contributor

javagl commented Mar 4, 2021

I assume that this will not only refer to CesiumGltf, but to ~"all" places where uint8_t was used (in a vector or span) to represent "bytes without inherent meaning".

@javagl
Copy link
Contributor

javagl commented Mar 4, 2021

This was addressed in #148 and CesiumGS/cesium-unreal#189 . There are a few more places that I expected where uint8_t was used to transport raw bytes. If any of them should remain uint8_t (despite being raw, non-arithmetic data), I'll update that accordingly.

@javagl
Copy link
Contributor

javagl commented Mar 5, 2021

Closed via #148

@javagl javagl closed this as completed Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants