Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bytes for raw data #148

Merged
merged 2 commits into from
Mar 5, 2021
Merged

Use bytes for raw data #148

merged 2 commits into from
Mar 5, 2021

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Mar 4, 2021

Addressing #117 :

This replaces the use of uint8_t with std::byte for spans and vectors that contain "raw" data (file data, request/responses etc).

One could probably argue about the use of std::byte vs. unsigned chat in places where the "raw" data is assumed to be JSON data. If there is a preference for unsigned char in thsese cases, I'll review that and integrate it where it can be applied sensibly.

Now, let's see where CLang spills out warnings that Visual Studio did not catch...

@kring kring merged commit 00dde7c into master Mar 5, 2021
@kring kring deleted the use-std-byte branch March 5, 2021 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants