Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #117 :
This replaces the use of
uint8_t
withstd::byte
for spans and vectors that contain "raw" data (file data, request/responses etc).One could probably argue about the use of
std::byte
vs.unsigned chat
in places where the "raw" data is assumed to be JSON data. If there is a preference forunsigned char
in thsese cases, I'll review that and integrate it where it can be applied sensibly.Now, let's see where CLang spills out warnings that Visual Studio did not catch...