Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more attribute semantics #1037

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Add more attribute semantics #1037

merged 2 commits into from
Dec 10, 2024

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Dec 9, 2024

From this comment: #959 (comment)

Adds

  • InstanceAttributeSemantics::TRANSLATION
  • InstanceAttributeSemantics::ROTATION
  • InstanceAttributeSemantics::SCALE
  • InstanceAttributeSemantics::FEATURE_ID_n
  • VertexAttributeSemantics::FEATURE_ID_n

@lilleyse
Copy link
Contributor Author

I would have gone with VertexAttributeSemantics::_FEATURE_ID_n but identifiers beginning with an underscore followed immediately by an uppercase letter are reserved in C++.

@kring
Copy link
Member

kring commented Dec 10, 2024

Thanks @lilleyse!

I would have gone with VertexAttributeSemantics::_FEATURE_ID_n but identifiers beginning with an underscore followed immediately by an uppercase letter are reserved in C++.

Kind of funny that C++ and glTF have opposite conventions here. In glTF, identifiers that don't start with an underscore are reserved.

@kring kring merged commit e221a63 into main Dec 10, 2024
22 checks passed
@kring kring deleted the more-attribute-semantics branch December 10, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lilleyse @kring