-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full support for multiple-b3dm-in-cmpt tiles, and some other fixes #109
Conversation
This is currently a PR into the |
I'm not quite convinced this is the right approach yet.
Upgrade draco index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kring this looks good to me. I only has a small comment below. After that, I think I can merge it into gltf
branch
|
||
template <typename T> | ||
struct MAT4 { | ||
T value[9]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems to be a typo. Is it supposed to be 16?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Fixed.
thanks @kring! San-Miguel model works correctly |
Builds on #102, #103, and #106, so merge those first.
extras
of loaded glTFs. cesium-unreal uses this to name the ActorComponents created from the glTFs, so that when you click on a tile in the editor, the URL of the tile is printed in the console.Fixes #104