Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PropertyAttributeView::forEachProperty #755

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

lilleyse
Copy link
Contributor

Fixes PropertyAttributeView::forEachProperty. The parameter order just needed to be swapped.

@csciguy8
Copy link
Contributor

Looks like a good fix @lilleyse.

Would be nice if our unit tests caught these compile errors first though. @j9liu any ideas?

@j9liu
Copy link
Contributor

j9liu commented Nov 13, 2023

@csciguy8 Yeah I didn't write tests for forEachProperty for any of the property views. It seemed a little awkward to test because each property is of a different type, so if we were going to thoroughly test multiple properties then you'd have to write a super specific / big callback.

I don't think that it should fall on @lilleyse to fix that so I'm happy to merge once CI passes. Thanks for the catch!

@j9liu j9liu merged commit b728cba into main Nov 13, 2023
14 checks passed
@j9liu j9liu deleted the fix-for-each-property branch November 13, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants