More tweaks to the shared asset system #965
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR into #964.
SharedAsset
andSharedAssetDepot
intoCesiumAsync
.SharedAssetSystem
toGltfSharedAssetSystem
and moved it toCesiumGltfReader
.SharedAsset::isShareable
. Even non-depot assets can be shared, so this method was misleading.this type can't be created directly.
Still to do:
SharedAssetDepot
with a Factory, instead of passing one in ongetOrFetch
call.ImageCesium
toImageAsset
.GltfSharedAssetSystem
just yet.