Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default constructor to ImageAsset #978

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

j9liu
Copy link
Contributor

@j9liu j9liu commented Nov 6, 2024

This is a small change to make the changes from #926 compatible with C++ 20. I previously got errors while trying to instantiate an empty ImageAsset, because its underlying SharedAsset constructor is protected. I'm not sure why this wasn't flagged in C++17, but oh well 🤷

@kring
Copy link
Member

kring commented Nov 6, 2024

Thanks @j9liu!

@kring kring merged commit 5b02dbd into main Nov 6, 2024
24 checks passed
@kring kring deleted the image-asset-default-constructor branch November 6, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants