Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Quick Checks" step on CI #509

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Fix "Quick Checks" step on CI #509

merged 1 commit into from
Sep 27, 2024

Conversation

kring
Copy link
Member

@kring kring commented Sep 27, 2024

We use ubuntu-latest to run the "Quick Checks" step, and ubuntu-latest very recently switched to Ubuntu 24.04. On 24.04, attempting to install clang-format via pip gives this error:

error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
    python3-xyz, where xyz is the package you are trying to
    install.
    
    If you wish to install a non-Debian-packaged Python package,
    create a virtual environment using python3 -m venv path/to/venv.
    Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
    sure you have python3-full installed.
    
    If you wish to install a non-Debian packaged Python application,
    it may be easiest to use pipx install xyz, which will manage a
    virtual environment for you. Make sure you have pipx installed.
    
    See /usr/share/doc/python3.12/README.venv for more information.

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP [6](https://github.com/CesiumGS/cesium-unity/actions/runs/11059061896/job/30737490347#step:3:7)68 for the detailed specification.

We could fix this by following the instructions in the error message. But there's really no need, because the GH Actions image already has clang-format installed. So this PR just removes that install step completely.

It's failing on Ubuntu 24.04, and probably (?) isn't needed anyway.
@kring kring added this to the October 2024 Release milestone Sep 27, 2024
@kring
Copy link
Member Author

kring commented Sep 27, 2024

I'm going to merge this once CI passes, because it is need to fix breakage in main.

@kring kring merged commit 966498e into main Sep 27, 2024
7 checks passed
@kring kring deleted the fix-build branch September 27, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant