Add UCesiumFlyToComponent #1227
Conversation
|
Thanks for the pull request @kring!
Reviewers, don't forget to make sure that:
|
| @@ -29,6 +29,8 @@ struct CESIUMRUNTIME_API FCesiumCustomVersion { | |||
| // built into the CesiumGeoreference. | |||
| OriginShiftComponent = 5, | |||
|
|
|||
| FlyToComponent = 6, | |||
There was a problem hiding this comment.
Add a comment for this version as well?
| FlyToComponent = 6, | |
| // Fly-to behavior is now an independent component rather than built into the GlobeAwareDefaultPawn. | |
| FlyToComponent = 6, |
| class UCesiumGlobeAnchorComponent; | ||
|
|
||
| UCLASS(ClassGroup = "Cesium", Abstract) | ||
| class CESIUMRUNTIME_API UCesiumActorComponentWithGlobeAnchor |
There was a problem hiding this comment.
This may be nitpicky, but can we move "Component" to the end of the class name for consistency with the Unreal component naming schemes? Maybe something like this would be better?
| class CESIUMRUNTIME_API UCesiumActorComponentWithGlobeAnchor | |
| class CESIUMRUNTIME_API UCesiumGlobeAnchoredActorComponent |
There was a problem hiding this comment.
UCesiumActorWithGlobeAnchorComponent was another alternative, but I went with UCesiumGlobeAnchoredActorComponent. But feel free to disagree if you think the new names are inaccurate.
| void _onFlightComplete(); | ||
|
|
||
| UFUNCTION() | ||
| void _onFlightInterrupted(); | ||
|
|
||
| /** | ||
| * @brief Advance the camera flight based on the given time delta. |
There was a problem hiding this comment.
_handleFlightStep and most of the variables below it are no longer used. Let's remove them
| * East-South-Up. | ||
| * | ||
| * If the component is attached to an Actor that is not a Pawn, or if the Pawn | ||
| * does not have a Controller, this option is equivalent to the the "Actor" |
There was a problem hiding this comment.
| * does not have a Controller, this option is equivalent to the the "Actor" | |
| * does not have a Controller, this option is equivalent to the "Actor" |
| /** | ||
| * A curve that controls what percentage of the maximum height the Actor | ||
| * should take at a given time on the flight. This curve must be kept in the 0 | ||
| * to 1 range on both axes. The {@see FlyToMaximumAltitudeCurve} controls the |
There was a problem hiding this comment.
| * to 1 range on both axes. The {@see FlyToMaximumAltitudeCurve} controls the | |
| * to 1 range on both axes. The {@see MaximumHeightByDistanceCurve} controls the |
|
All your changes look great to me. Thanks for the review and fixes @j9liu! |
|
I'm merging this for the v2.0 preview. Further review comments still welcome. |
Fixes #1155
This takes the "flight" functionality that was previously in GlobeAwareDefaultPawn and makes it into a component that can be added to anything. So you can do flights with other pawns, or even fly random models around the world or whatever.
Backward compatibility was tricky, but basically Blueprints using the old flight functionality on GlobeAwareDefaultPawn should continue to work (with warnings). C++ code will need changes. DynamicPawn includes a CesiumFlyToComponent. A GlobeAwareDefaultPawn saved in previous versions will gain one when it's upgraded, but users will have to add it manually to new GlobeAwareDefaultPawns.
Other changes here:
CesiumActorComponentWithGlobeAnchor, which is just a convenience base class for ActorComponents that require that a GlobeAnchor also be attached to the same Actor. CesiumOriginShiftComponent and CesiumFlyToComponent both derive from this.FloatingPawnthat has been deprecated for over two years now.