Don't use std::variant
in FCesiumPropertyTableProperty
#1241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PropertyTablePropertyViewType
was atypedef
for a largestd::variant
defined in Cesium Native. It was so large that all of the normalized property versions had to be put in their ownstd::variant
, and the two were then grouped under their ownstd::variant
in Cesium for Unreal. While Visual Studio's compiler was able to handle this well, Clang would experience incredibly slow compilation times and often would not be able to complete CI.This replaces the
std::variant
with astd::any
. The original property type is stored in theFCesiumMetadataValueType
, and the struct can be used to re-find the C++ type tostd::any_cast
to. This allows Clang + CI to finally compile successfully, and to somewhat reduce the size of our object files.