-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix raster overlay undefined behavior #1554
Conversation
Also add an assertion to check for the problem.
Trying to test this and CesiumGS/cesium-native#1003 out and I'm getting a lot of errors relating to the changes in main, particularly over gsl::span:
Does this PR then also depend on #1539? It seemed to be non-trivial getting the ue55 branch merged into this one to test it out, so I didn't go that far. |
Yeah, after the C++20 upgrade PRs were merged into cesium-native main, and main was merged into CesiumGS/cesium-native#1003, this became dependent on #1539. I merged that branch into here and changed the base branch accordingly. |
Looks great! Thanks @kring! |
This is a PR into #1552 so merge that first.
This depends on CesiumGS/cesium-native#1003 so merge that first, too.
Fixes #1551