Rename vertex-specific functions in FCesiumFeatureIdAttribute
#1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j9liu
commented
Dec 23, 2024
| */ | ||
| UFUNCTION( | ||
| BlueprintCallable, | ||
| BlueprintPure, | ||
| Category = "Cesium|Features|FeatureIDAttribute") | ||
| static int64 | ||
| GetVertexCount(UPARAM(ref) | ||
| const FCesiumFeatureIdAttribute& FeatureIDAttribute); | ||
| GetFeatureIDCount(UPARAM(ref) |
There was a problem hiding this comment.
This might be a bit confusing on second glance -- I don't want this to convey the # of actual unique feature IDs versus. the length of the attribute. Let me tweak this
There was a problem hiding this comment.
Settled on GetCount with some additional documentation. Open to other alternatives too.
|
@kring do you mind giving this a review? |
|
Looks good, thanks @j9liu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #1537 the
FCesiumFeatureIdAttributeclass gets used for both per-vertex and per-instance feature IDs. This makes the "vertex" verbiage in the API inaccurate.This PR renames those functions so they are more generic. I added
Redirectsso that Blueprints can seamlessly pick up the new functions. If you'd like, you can test this by: