cleanup: Remove VoxelPrimitive.jitter option (#11913)

CesiumGS · Aug 22, 2024 · 9e35beb · 9e35beb
1 parent 6545ff7
commit 9e35beb
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 30 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -10,6 +10,8 @@
 
 - Exposes `ScreenSpaceCameraController.zoomFactor` to allow adjusting the zoom factor (speed). [#9145](https://github.com/CesiumGS/cesium/pull/9145)
 
+- Removed `jitter` option from `VoxelPrimitive.js` and related test code in `VoxelPrimitiveSpec.js`. [#11913](https://github.com/CesiumGS/cesium/issues/11913)
+
 ##### Fixes :wrench:
 
 - Fixed cube-mapping artifacts in image-based lighting. [#12100](https://github.com/CesiumGS/cesium/pull/12100)

diff --git a/packages/engine/Source/Scene/VoxelPrimitive.js b/packages/engine/Source/Scene/VoxelPrimitive.js
@@ -332,12 +332,6 @@ function VoxelPrimitive(options) {
   this._transformNormalLocalToWorld = new Matrix3();
 
   // Rendering
-  /**
-   * @type {boolean}
-   * @private
-   */
-  this._jitter = false;
-
   /**
    * @type {boolean}
    * @private
@@ -704,29 +698,6 @@ Object.defineProperties(VoxelPrimitive.prototype, {
     },
   },
 
-  /**
-   * Gets or sets whether or not to jitter the view ray during the raymarch.
-   * This reduces stair-step artifacts but introduces noise.
-   *
-   * @memberof VoxelPrimitive.prototype
-   * @type {boolean}
-   */
-  jitter: {
-    get: function () {
-      return this._jitter;
-    },
-    set: function (jitter) {
-      //>>includeStart('debug', pragmas.debug);
-      Check.typeOf.bool("jitter", jitter);
-      //>>includeEnd('debug');
-
-      if (this._jitter !== jitter) {
-        this._jitter = jitter;
-        this._shaderDirty = true;
-      }
-    },
-  },
-
   /**
    * Gets or sets the nearest sampling.
    *

diff --git a/packages/engine/Specs/Scene/VoxelPrimitiveSpec.js b/packages/engine/Specs/Scene/VoxelPrimitiveSpec.js
@@ -78,7 +78,6 @@ describe(
       });
 
       toggleOption("depthTest", true, false);
-      toggleOption("jitter", false, true);
       toggleOption("nearestSampling", false, true);
     });
-Original file line number
+Diff line change
@@ Expand Up / @@ -78,7 +78,6 @@ describe( @@
           });
           toggleOption("depthTest", true, false);
-          toggleOption("jitter", false, true);
           toggleOption("nearestSampling", false, true);
         });
@@ Expand Down @@