Fix voxel picking spec #11963
Merged
Fix voxel picking spec #11963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request, @jjhembd! ✅ We can confirm we have a CLA on file for you. |
|
This is fixed for me! Thanks @jjhembd! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test of
Scene.pickVoxelinPickingSpecwas failing due to the voxel being out of view.This PR switches the spec to the box-shaped tileset for simplicity, and adjusts the model matrix to ensure the voxel is within view.
Issue number and link
Resolves #11916
Testing plan
Run
PickingSpeclocally. Note: local testing is necessary, because this spec does not run in CI. The webGL stub used in CI triggers a dummy matcher for picking specs, which always passes.Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change