Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix computation of model bounding volume #12112

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix computation of model bounding volume #12112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df44aea
Compute model bounds from transformed primitive bounds
javagl Aug 7, 2024
fc71669
Compute proper bounding spheres - preliminary!
javagl Aug 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/engine/Source/Scene/Model/InstancingPipelineStage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,9 @@ function getInstanceTransformsAsMatrices(instances, count, renderResources) {

// Unload the typed arrays. These are just pointers to the arrays
// in the vertex buffer loader.
// XXX NO, DON'T FRIGGIN "UNLOAD" SOMETHING IN A FUNCTION
// THAT HAS A NAME THAT STARTS WITH "get"!!!
/*
if (hasTranslation) {
translationAttribute.typedArray = undefined;
}
Expand All @@ -625,7 +628,7 @@ function getInstanceTransformsAsMatrices(instances, count, renderResources) {
if (hasScale) {
scaleAttribute.typedArray = undefined;
}

*/
return transforms;
}

Expand Down Expand Up @@ -675,7 +678,9 @@ function getInstanceTranslationsAsCartesian3s(

// Unload the typed array. This is just a pointer to the array
// in the vertex buffer loader.
translationAttribute.typedArray = undefined;
// XXX NO, DON'T FRIGGIN "UNLOAD" SOMETHING IN A FUNCTION
// THAT HAS A NAME THAT STARTS WITH "get"!!!
//translationAttribute.typedArray = undefined;

return instancingTranslations;
}
Expand Down
Loading
Loading