Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing CallbackProperty type that is supposed to be here #12120

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

Levi-Montgomery
Copy link

Description

I added a missing type, you are supposed to be able to update entity position with a callback property.

Previously you would get a type error when trying to update the entity position with a callback (a supported feature). This could be worked around by ignoring the type error but this is a proper fix.

Issue number and link

Testing plan

I see type error go away

Author checklist

  • [X ] I have submitted a Contributor License Agreement
  • [ X] I have added my name to CONTRIBUTORS.md
  • [ X] I have updated CHANGES.md with a short summary of my change
  • [ X] I have added or updated unit tests to ensure consistent code coverage
  • [ X] I have updated the inline documentation, and included code examples where relevant
  • [ X] I have performed a self-review of my code

Copy link

Thank you for the pull request, @Levi-Montgomery!

✅ We can confirm we have a CLA on file for you.

@ggetz
Copy link
Contributor

ggetz commented Aug 12, 2024

Thanks for the fix @Levi-Montgomery!

@ggetz ggetz merged commit be2aad4 into CesiumGS:main Aug 12, 2024
4 checks passed
@Levi-Montgomery Levi-Montgomery deleted the fix-type branch October 2, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants