make screenSpaceCameraController zoomFactor public. #12121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request, @BeyondBelief96! ✅ We can confirm we have a CLA on file for you. |
ggetz
requested changes
Aug 13, 2024
There was a problem hiding this comment.
Fantastic, thanks @BeyondBelief96! I just have one comment about CHANGES.md and this should be good to go.
…eyondBelief96/cesium into issues/7898/expose-zoom-factor
|
Should be good to go! |
ggetz
approved these changes
Aug 13, 2024
|
Awesome, thanks @BeyondBelief96! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change exposes the zoomFactor property on the
ScreenSpaceCameraController, making it public.This change was originally requested here: #9145 (comment)
However the original author closed his PR. This is simply implementing his changes again.
This change would allow users to customize the zoom factor of the cesium engine. My main use case is to allow mobile users of my application to have an easier time zooming in and out by changing zoom factor, allowing the pinch-to-zoom gestures to have more drastic zoom changes. The current zoom amount per pinch-to-zoom motion is frustratingly slow.
Issue number and link
#7978
Testing plan
Add unit tests.
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change