Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated file extension check (tiny change) #12127

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

adamwirth
Copy link
Contributor

@adamwirth adamwirth commented Aug 15, 2024

Description

Looks like it was checking \.gpx$ twice. Is there some other file suffix to replace the second check with instead of removing it entirely?

Issue number and link

N/A

Testing plan

Linting level change.
Should I be adding my name to contributors.md/changes.md if I am just editing something so miniscule? That feels insincere somehow, compared to other PRs' work.

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Looks like it was checking \.gpx$ twice. Is there some other file suffix to replace it with?
Copy link

Thank you for the pull request, @adamwirth!

✅ We can confirm we have a CLA on file for you.

@ggetz
Copy link
Contributor

ggetz commented Aug 22, 2024

Thanks for the fix @adamwirth! This fix looks good to me.

Could you please add yourself to CONTRIBUTORS.md?

@adamwirth
Copy link
Contributor Author

Thanks for the fix @adamwirth! This fix looks good to me.

Could you please add yourself to CONTRIBUTORS.md?

Added!

@ggetz
Copy link
Contributor

ggetz commented Aug 26, 2024

Great! Thanks @adamwirth!

@ggetz ggetz merged commit e12391d into CesiumGS:main Aug 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants