Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return first geometryBuffer if no best match found #12132

Closed
wants to merge 1 commit into from

Conversation

ljowen
Copy link
Contributor

@ljowen ljowen commented Aug 19, 2024

Description

If no exact match by attribute is found in _findBestGeometryBuffers return the first one. I believe this was the original intention with this function returning 0 for the index.

This allows I3S Scenes to render with geometries missing either ["position", "uv0"] (See issue / sandcastle).

Issue number and link

Fixes #12114

Testing plan

  • Create sandcastle with the following added as an I3S dataProvider:
    • https://basemaps3d.arcgis.com/arcgis/rest/services/OpenStreetMap3D_Buildings_v1/SceneServer?layers=ca0470dbbddb4db28bad74ed39949e25
  • Verify the scene renders and errors are no longer thrown
  • Confirm other I3S scenes are rendering fine

Sandcastle Link

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@ljowen ljowen changed the title Return first geometryBuffer if no best batch found Return first geometryBuffer if no best match found Aug 19, 2024
Copy link

Thank you for the pull request, @ljowen!

✅ We can confirm we have a CLA on file for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I3SNode requesting 'undefined' geometry buffer
1 participant